Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Android 13, added "fineLocation" option #460

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

giuseppelanzi
Copy link

I submit this PR in order to be able to fix the plugin for Android 12 and 13.

In addition I added a fineLocation option in the discover process. Some users reported that they find awkward to give location accesso in order to link to a bluetooth printer (sounds like a reasonable thing to say).

Hope it helps.

@giuseppelanzi
Copy link
Author

@don Please merge these changes..otherwise we have do lot f manual work while generating apk ..

If you need to quickly add my forked code to a cordova project, you can add the plugin in cordova using cordova plugin add https://github.com/giuseppelanzi/BluetoothSerial#30f0d6d229dc76d6a24cc3f7f27b345d25c4f893 --nofetch.

@giuseppelanzi
Copy link
Author

I was thinkng abount cloning this repo and adding to npm with another name. Don't want to mess with other developers but in the current state the plugin can't be used.

@don would it be ok for you?

@lajith111
Copy link

@don Please merge these changes..otherwise we have do lot f manual work while generating apk ..

If you need to quickly add my forked code to a cordova project, you can add the plugin in cordova using cordova plugin add https://github.com/giuseppelanzi/BluetoothSerial#30f0d6d229dc76d6a24cc3f7f27b345d25c4f893 --nofetch.

Thanks but i am using capacitor https://github.com/danielsogl/awesome-cordova-plugins currently i am replacing java code in the file which generates BluetoothSerial.java

@giuseppelanzi
Copy link
Author

Made another change. The requestPermissionCallback() go always with discoverUnpaired() and so if the users needs to give permission for another functionality (like simple scan or list of paired devices) the discovering is started anyway.

In my PR the application goes on with only the proper method.

@don I'm thinking on cloning the repo to registering it on npm. If I do, the open license will be respected and you will always be cited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants